Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support time-dependent operators in timeevolution #366

Merged
merged 4 commits into from
Jul 5, 2023

Conversation

amilsted
Copy link
Collaborator

This accompanies qojulia/QuantumOpticsBase.jl#104. Tests won't pass until those changes are included.

Provides methods for "dynamic" time evolution that take time-dependent operators directly.

@Krastanov
Copy link
Collaborator

@mabuni1998 , similarly to my comment on qojulia/QuantumOpticsBase.jl#104 , this is something that will probably be of interest to you in the context of WaveguideQED.jl

@Krastanov
Copy link
Collaborator

Any chance you have the bandwidth to mention these in the documentation? Either way, we should probably create an issue about the need for more extensive documentation and examples using these new types of operators.

@amilsted
Copy link
Collaborator Author

Any chance you have the bandwidth to mention these in the documentation? Either way, we should probably create an issue about the need for more extensive documentation and examples using these new types of operators.

Yeah, docs are lagging a bit in general. Should provide some examples or tutorials for this too. I can add some minimal documentation and a simple example for now.

@amilsted amilsted changed the title RFC: Support time-dependent operators in timeevolution Support time-dependent operators in timeevolution Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #366 (561939b) into master (9284519) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   98.05%   98.11%   +0.06%     
==========================================
  Files          17       18       +1     
  Lines        1442     1488      +46     
==========================================
+ Hits         1414     1460      +46     
  Misses         28       28              
Impacted Files Coverage Δ
src/QuantumOptics.jl 100.00% <ø> (ø)
src/master.jl 100.00% <100.00%> (ø)
src/mcwf.jl 100.00% <100.00%> (ø)
src/schroedinger.jl 94.00% <100.00%> (+0.25%) ⬆️
src/time_dependent_operators.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amilsted
Copy link
Collaborator Author

@Krastanov I have docs and examples PRs ready to go also (although I don't know how to deploy the main docs!). I think this is ready from my perspective.

@Krastanov
Copy link
Collaborator

LGTM

@amilsted amilsted merged commit 9ad920c into qojulia:master Jul 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants